Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed query and added tip for environment #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AWolf81
Copy link

@AWolf81 AWolf81 commented Mar 14, 2015

Table search.news seems to be dropped. The code was not working. Added tip with environment to access community tables and added link to a demo jsfiddle.

@arthurvr
Copy link
Member

@AWolf81 Could you please sign the CLA?

@AWolf81
Copy link
Author

AWolf81 commented Apr 13, 2015

I signed the CLA several days ago. Sorry, that I haven't left a comment after signing.

@arthurvr
Copy link
Member

@AWolf81 As explained on the page, could you please push a new commit or force push the existing one so the bot runs again?


jQuery handles all the complex aspects of JSONP behind-the-scenes — all we have to do is tell jQuery the name of the JSONP callback parameter specified by YQL ("callback" in this case), and otherwise the whole process looks and feels like a normal Ajax request.

You can find a working demo of the code in this [jsFiddle](http://jsfiddle.net/awolf2904/18kk18tj/).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this empty line?

@arthurvr
Copy link
Member

arthurvr commented Jun 6, 2015

@AWolf81 The git author on the commit contains your user name, not your full name. Mind updating that? I believe that's the reason why the CLA check fails as well.

@AWolf81
Copy link
Author

AWolf81 commented Jun 6, 2015

I've changed the user name in the last commit to my full name but do I need to change the name in the older commits too? If yes, how can I do it? I'm pretty new to git.

@arthurvr
Copy link
Member

arthurvr commented Jun 7, 2015

I've changed the user name in the last commit to my full name but do I need to change the name in the older commits too? If yes, how can I do it? I'm pretty new to git.

I'd say just squash the commits, that needs to happen anyways.

table search.news seems to be dropped. Added tip with environment to access community tables and added link to a demo jsfiddle.

Added blank line after code block & removed blank lines at the end

removed link to jsfiddle. Not really needed.
Base automatically changed from master to main March 8, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants