-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed query and added tip for environment #640
base: main
Are you sure you want to change the base?
Conversation
@AWolf81 Could you please sign the CLA? |
I signed the CLA several days ago. Sorry, that I haven't left a comment after signing. |
@AWolf81 As explained on the page, could you please push a new commit or force push the existing one so the bot runs again? |
page/ajax/working-with-jsonp.md
Outdated
|
||
jQuery handles all the complex aspects of JSONP behind-the-scenes — all we have to do is tell jQuery the name of the JSONP callback parameter specified by YQL ("callback" in this case), and otherwise the whole process looks and feels like a normal Ajax request. | ||
|
||
You can find a working demo of the code in this [jsFiddle](http://jsfiddle.net/awolf2904/18kk18tj/). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this empty line?
@AWolf81 The git author on the commit contains your user name, not your full name. Mind updating that? I believe that's the reason why the CLA check fails as well. |
I've changed the user name in the last commit to my full name but do I need to change the name in the older commits too? If yes, how can I do it? I'm pretty new to git. |
I'd say just squash the commits, that needs to happen anyways. |
table search.news seems to be dropped. Added tip with environment to access community tables and added link to a demo jsfiddle. Added blank line after code block & removed blank lines at the end removed link to jsfiddle. Not really needed.
Table search.news seems to be dropped. The code was not working. Added tip with environment to access community tables and added link to a demo jsfiddle.