Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selecting-elements.md #564

Closed
wants to merge 1 commit into from
Closed

Conversation

SoldierKB
Copy link
Contributor

Formatted in paragraph for :checked selector

Formatted <select> in paragraph for :checked selector
@arthurvr
Copy link
Member

arthurvr commented Dec 5, 2014

What your including isn't correct. We're in this case talking about elements, not about tags. Those shouldn't be wrapped within < and >. If you don't really understand the difference, I recommend to checkout http://perfectionkills.com/tag-is-not-an-element-or-is-it/.

This is a misconception made frequently.

@SoldierKB
Copy link
Contributor Author

Ok, thanks for the link, it was interesting and I wasn't aware of it.
But have a look around this paragraph - above we have "any elements", as well as "any elements". So this type of brackets IS used here to denote HTML elements to avoid ambiguity. In the context we are talking about element to make distinction in the text it's HTML element, not just "select" word. And at the end we have "applies to or elements".
If we have it that way here - it should be that way, elsewhere the whole article should we rewritten. Isn't it ambiguous?

@arthurvr
Copy link
Member

arthurvr commented Dec 8, 2014

It's technically incorrect too, but let's not care about that. Everybody does it.

Best solution would in my opinion be to just wrap it between backticks. That would directly clarify that it's a technical term, not plain english. Overall technical stuff is wrapped between backticks in the site. Wanne PR?

tons, and `select` elements (for `select` elements 

@scottgonzalez
Copy link
Member

We use "<select> elements" in jQuery content.

Note that this can only be discovered by browsing lots of existing content. This isn't currently covered in any of the various style guides right now. This needs to be covered in jquery/contribute.jquery.org#75.

@scottgonzalez scottgonzalez reopened this Dec 8, 2014
@arthurvr
Copy link
Member

arthurvr commented Dec 8, 2014

This needs to be covered in jquery/contribute.jquery.org#75.

Ya surely. Ready to merge this one then. We'il discuss this in there later.

@SoldierKB
Copy link
Contributor Author

So sorry, but I didn't really get it - should it be changed as I proposed or not? And later changed (fixed) every incorrect <...> to ...?

@arthurvr
Copy link
Member

arthurvr commented Dec 9, 2014

Nope, your PR was fine then. This should be included in the language style guide, but that's no reason to let this PR wait longer.

@SoldierKB
Copy link
Contributor Author

Sorry again, I'm a little new to github and don't know/understand everything. Don't you mind me asking?
Who should approve my pull request? There are only several people who can do it, right? And we wait for one of this people to come, check PR and approve it in case everything is fine?
My previous PR is closed with unmerged commits, even though my changes are in master\on the page.
I just don't get how it works :).

@arthurvr
Copy link
Member

arthurvr commented Dec 9, 2014

Who should approve my pull request? There are only several people who can do it, right? And we wait for one of this people to come, check PR and approve it in case everything is fine?

Yes. Just to wait for somebody to merge this ;-)

My previous PR is closed with unmerged commits, even though my changes are in master\on the page.

It's merged, but with a little modifications then. Mostly that's just a little correction, or just the commit message which is changed.

@SoldierKB
Copy link
Contributor Author

Thanks for explanation, I got it now. Thank you for you help and time, I really appreciate it!

@arthurvr
Copy link
Member

arthurvr commented Dec 9, 2014

By looking at the commit that closes your PR. For #401, that was 2510bdb.

For that PRs, the commits were just squashed together & the commit message changed.

Don't worry, when you start doing more, you'il learn it.

@RedWolves RedWolves closed this in 26b34b1 Dec 25, 2014
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
…sentation in content.

Closes gh-564

Formatted <select> in paragraph for :checked selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants