-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update selecting-elements.md #564
Conversation
Formatted <select> in paragraph for :checked selector
What your including isn't correct. We're in this case talking about elements, not about tags. Those shouldn't be wrapped within This is a misconception made frequently. |
Ok, thanks for the link, it was interesting and I wasn't aware of it. |
It's technically incorrect too, but let's not care about that. Everybody does it. Best solution would in my opinion be to just wrap it between backticks. That would directly clarify that it's a technical term, not plain english. Overall technical stuff is wrapped between backticks in the site. Wanne PR? tons, and `select` elements (for `select` elements |
We use " Note that this can only be discovered by browsing lots of existing content. This isn't currently covered in any of the various style guides right now. This needs to be covered in jquery/contribute.jquery.org#75. |
Ya surely. Ready to merge this one then. We'il discuss this in there later. |
So sorry, but I didn't really get it - should it be changed as I proposed or not? And later changed (fixed) every incorrect <...> to |
Nope, your PR was fine then. This should be included in the language style guide, but that's no reason to let this PR wait longer. |
Sorry again, I'm a little new to github and don't know/understand everything. Don't you mind me asking? |
Yes. Just to wait for somebody to merge this ;-)
It's merged, but with a little modifications then. Mostly that's just a little correction, or just the commit message which is changed. |
Thanks for explanation, I got it now. Thank you for you help and time, I really appreciate it! |
…sentation in content. Closes gh-564 Formatted <select> in paragraph for :checked selector
Formatted in paragraph for :checked selector