change http to https where applicable #140
Conversation
No, this is specifying a host, not a page to request. The download.jqueryui.com domain does exist and is used, it just doesn't serve an index page.
I haven't looked through all the changes yet, but if you did a blank search and replace, this will cause bad URLs.
Ok.
We don't control that. These URLs should stay as HTTP.
I suppose we can update this purely for the sake of not having a dead link.
Thanks! I'll go through all the updates to make sure there are no issues. |
| @@ -12,7 +12,7 @@ The process for designing and planning the future of the jQuery UI library shoul | |||
|
|
|||
| ### Flexible styling and themes | |||
|
|
|||
| Widgets should provide hooks to enable developers to customize both behavioral and presentational aspects. Transition animations should be optional and customizable. Class names used on internal elements should be meaningful to jQuery UI users and enable styling either through [ThemeRoller](http://jqueryui.com/themeroller/) or hand-written CSS via the [jQuery UI CSS Framework](http://learn.jquery.com/jquery-ui/theming/). As much as possible, style attributes should be separated into the plugin's CSS, not within the scripts in order to make customization simple and clear. Widgets styles should be coded with proportional (em-based or % based) sizing and should re-flow horizontally to fill the space provided. | |||
| Widgets should provide hooks to enable developers to customize both behavioral and presentational aspects. Transition animations should be optional and customizable. Class names used on internal elements should be meaningful to jQuery UI users and enable styling either through [ThemeRoller](https://jqueryui.com/themeroller/) or hand-written CSS via the [jQuery UI CSS Framework](https://learn.jquery.com/jquery-ui/theming/). As much as possible, style attributes should be separated into the plugin's CSS, not within the scripts in order to make customization simple and clear. Widgets styles should be coded with proportional (em-based or % based) sizing and should re-flow horizontally to fill the space provided. | |||
There was a problem hiding this comment.
We need to be careful with changes to anything related to download builder because the resources are managed in a different repo. We'll need download.jqueryui.com to be updated first, or at least at the same time.
|
I'll fix these things in a bit, the part about bad spacing. You should add an editorconfig so things like this don't happen. I have my editor set my default to 4 spaces instead of tabs. |
We've got a discussion about this going on in jquery/contribute.jquery.org#129 and qunitjs/api.qunitjs.com#115. |
http://download.jqueryui.comredirects tohttps://jqueryui.com/download/, should this be changed inGruntfile.js?http://ui.jquery.com/bugsredirects tohttps://jqueryui.com/bugsbut that doesn't exit, what should this be changed to?https://ui.jquery.com/bugsredirects tohttps://jquery.com/not sure why it doesn't match above.http://code.google.com/p/jquery-uiredirects tohttps://github.com/jquery/jquery-uiso I updated the links.http://groups.google.com/group/jquery-a11yredirects tohttps://groups.google.com/forum/#!forum/jquery-a11yso I updated the links.https://wiki.jqueryui.comhas an incorrect SSL cert.http://xregexp.com/xregexp.jsdoesn't exist anymore, the site does though.http://jquery.github.com/cla.htmlis now athttps://contribute.jquery.org/CLA/so that's updated.