-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs:Tests: Remove obsolete code from tests, update support comments #2949
Conversation
I could update the support comments to conform to @gibson042's proposal at jquery/contribute.jquery.org#95 (comment) since I'm already modifying a lot of them. Do we have a consensus on that? (This would involve changing some |
// XHTML parsers do not magically insert elements in the | ||
// same way that tag soup parsers do. So we cannot shorten | ||
// this by omitting <tbody> or other required elements. | ||
option: [ 1, "<select multiple='multiple'>", "</select>" ], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extraneous line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to separate option
from the table-related entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you would like to move code around, that just creates trash in the blame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not "moving code around", I just thought the XHTML-related comment applies to this line as well. Doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i recall, we know that would break only in table elements
23cf92c
to
578d1ec
Compare
Support comments that were lacking the final IE/Edge version that exhibits the bug were checked & updated. Links to the Chromium bug tracker were updated. Code in tests related to unsupported browsers (like Android 2.3 in non-basic tests) has been removed. Fixes jquerygh-2868 Closes jquerygh-2949
578d1ec
to
9b08688
Compare
Support comments that were lacking the final IE/Edge version that exhibits
the bug were checked & updated. Links to the Chromium bug tracker were updated.
Code in tests related to unsupported browsers (like Android 2.3 in non-basic
tests) has been removed.
Fixes gh-2868
The first commit is PR #2948, I just didn't want to introduce conflicts between my 2 PRs. I'll rebase once that lands.