jquery: Make code-listing line numbers unselectable #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent accidental inclusion of the line numbers, when copy-pasting from syntaxhighlighter code blocks. Also use -webkit-user-select for Safari (desktop & mobile). Signed-off-by: FeRD (Frank Dana) <[email protected]>
|
|
mgol
requested changes
Dec 13, 2022
Co-authored-by: Michał Gołębiowski-Owczarek <[email protected]>
mgol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the well-supported1
user-select: noneCSS property on the line number gutter in syntaxhighlighter code blocks, to prevent accidental inclusion when copy-pasting the contained code.Notes
user-select: nonehas broad browser support, both Safari versions do require its use as the vendor-prefixed-webkit-user-select(also included in the PR changes).(CLA Note: As I mentioned in jquery/contribute.jquery.org#149, the CLA links across the documentation are currently linking to an OpenJSF page with no CLA in evidence. I have not signed the CLA simply because I can't find any way to sign it.)Never mind, the bot's link worked.