-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-passive event listeners issue and add a updated version number #215
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is essentially a noop but it doesn't work in IE which has no support for passive listeners. The upstream jQuery also doesn't use a pattern like this so I'm not in favor.
@dmethvin what do you think?
Could it be put behind a compatibility layer for non-IE? |
Yes, it could, but it'd still be adding lots of bytes just to silence browser warnings without any actual change in behavior. If we were doing that for jQuery as well it'd make sense but I'm not sure about doing it just in this plugin, diverging from the upstream. |
Okay, so the ideal thing to do is icebox this and have passive event listeners adopted in JQ core? |
Yes, I think that’s the best option here.--
Michał Gołębiowski-Owczarek
|
@mgol Internet Explorer 11 desktop application will be retired and go out of support on June 15, 2022. Therefore this repo shouldn't continue to support ie11 after end of life date reached. |
This project will most likely keep following the browser support policy of jQuery and there are no plans to drop IE 11 support there yet. |
Relates to (my old account) issue found here: #202
Have tested this and works fine.