Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added http://learn.jquery.com/style-guide/ to http://contribute.jquery.o... #87

Closed
wants to merge 11 commits into from
Closed

Conversation

pablofiumara
Copy link
Contributor

...rg/style-guide/prose/

This is a draft. Suggestions are welcome.

@pablofiumara
Copy link
Contributor Author

This is a draft of the solution to issue #75

@@ -8,6 +8,9 @@ Our style guides aim to make the code bases appear as if they were written by on

Long term, we would like to have all of the formatting automatically done by the build process, so that the resulting code would always follow the style guide. We haven't reached that nirvana yet, but we have taken a few steps in that direction. For example, our projects contain an [EditorConfig file](http://editorconfig.org) that many programming editors can use to enforce the space and tab rules. Our [JSHint](http://www.jshint.com/about/) configuration checks for common style _faux pas_ such as trailing spaces on a line, or using a variable before it is defined.


### [General Style Guide](/style-guide/prose/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prose Style Guide

@pablofiumara
Copy link
Contributor Author

Scott, could you tell me if anymore changes are needed, please?

@mikesherov
Copy link
Member

ping @scottgonzalez

@@ -0,0 +1,113 @@
---
title: Prose Style Guide
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be JSON.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottgonzalez Excuse me, what do you mean when you say that this should be "JSON"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at any of the other pages. They all use JSON instead of YAML.

<script>{
    "title": "Prose Style Guide"
}</script>


## Writing Style

Content should be educational and accessible to a broad audience of developers. The primary target audience is beginning to intermediate jQuery users, with advanced jQuery users as a secondary audience. When creating content, please keep one of these audiences in mind as well as the following style guidelines:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was written for the learn site and needs to be changed to apply to all documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottgonzalez Could you give some guidelines to start working on this, please?

@arthurvr
Copy link
Member

@pablofiu Would you mind updating the PR and address the things mentioned above? Thanks! :)

@pablofiumara
Copy link
Contributor Author

@arthurvr I will resume work in this PR tomorrow. I will keep updated of all you.

@pablofiumara
Copy link
Contributor Author

I deleted my fork and unfortunately was not able to add more commits to this pull request. That is why I created a new one: #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants