Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds finalizers to native objects. Note that I'm using
sp_close
as aSerialPort
finalizer which is much more important thansp_free_port
since it allows to re-open serial port after Flutter's Hot Restart.While it's perfectly fine to have more than one native finalizer for the same object, Dart SDK does not make guarantees about their execution order. So if you try to add
sp_free_port
finalizer as well, it might be called beforesp_close
finalizer (depending on the environment or Dart SDK version). Ideally underlyinglibserialport
will have something likesp_dispose
with deterministic order (close and free).Closes #68