Allow to disable port on services. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test where you disable the ldap port and test the replication (writing a entry and reading it) ? You can check on existing tests |
When using service as load balancer, if we setup ldap to be on secure port only we don't want to expose the insecure port. Currently there is no way to do that. With this modification, users can enable or disable exposition of insecure or secure port on the service. Default values keep the current behaviour. Signed-off-by: Guillaume Perrin <[email protected]>
guillomep
force-pushed
the
allow_disable_port_svc
branch
4 times, most recently
from
4fe8524
to
585668d
Compare
Signed-off-by: Guillaume Perrin <[email protected]>
guillomep
force-pushed
the
allow_disable_port_svc
branch
from
585668d
to
a8fedd8
Compare
Signed-off-by: Guillaume Perrin <[email protected]>
guillomep
force-pushed
the
allow_disable_port_svc
branch
from
ef52227
to
e32c462
Compare
Signed-off-by: Guillaume Perrin <[email protected]>
Signed-off-by: Guillaume Perrin <[email protected]>
|
@jp-gouin Okay I think I manage to create tests Is that okay for you ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using service as load balancer, if we setup ldap to be on secure port only we don't want to expose the insecure port. Currently there is no way to do that.
With this modification, users can enable or disable exposition of insecure or secure port on the service.
Default values keep the current behaviour.
Pre-submission checklist: