Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow IPv6 on ltb-passwd #127

Closed
wants to merge 1 commit into from
Closed

fix: Allow IPv6 on ltb-passwd #127

wants to merge 1 commit into from

Conversation

SuperQ
Copy link

@SuperQ SuperQ commented Sep 30, 2023

What this PR does / why we need it:

  • Listen on both IPv4 and IPv6 in the ltb-passwd to fix health probes on dual-stack clusters.
  • Include upstream chart env in main values.yaml.

tiredofit/docker-self-service-password#66

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you updated the readme?
  • Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first

* Listen on both IPv4 and IPv6 in the ltb-passwd to fix health probes on
  dual-stack clusters.
* Include upstream chart env in main values.yaml.

tiredofit/docker-self-service-password#66

Signed-off-by: SuperQ <[email protected]>
Copy link

stale bot commented Nov 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 29, 2023
@SuperQ
Copy link
Author

SuperQ commented Nov 29, 2023

Not stale, just need review by @jp-gouin

@stale stale bot removed the wontfix This will not be worked on label Nov 29, 2023
Copy link

stale bot commented Jan 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 28, 2024
@SuperQ
Copy link
Author

SuperQ commented Jan 28, 2024

Still not stale

@stale stale bot removed the wontfix This will not be worked on label Jan 28, 2024
Copy link

stale bot commented Mar 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 29, 2024
@SuperQ
Copy link
Author

SuperQ commented Mar 29, 2024

Still waiting

@stale stale bot removed the wontfix This will not be worked on label Mar 29, 2024
Copy link

stale bot commented May 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 29, 2024
@SuperQ
Copy link
Author

SuperQ commented May 29, 2024

Still waiting

@stale stale bot removed the wontfix This will not be worked on label May 29, 2024
@jp-gouin
Copy link
Owner

jp-gouin commented Jun 7, 2024

Hi @SuperQ ,
I'm not sure your issue need a fix in the values as the chart already allows you specifying ltb-passwd.env

Maybe would make more sense to add the info in the readme ?

I know it's been a while , so feel free to close the PR and I'll include the variable in the readme in the next update

@SuperQ
Copy link
Author

SuperQ commented Jun 7, 2024

I don't really mind how it is changed, but I think the defaults for this chart should work correctly with dual stack by default.

Copy link

stale bot commented Aug 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 6, 2024
@SuperQ
Copy link
Author

SuperQ commented Aug 6, 2024

Still would like to see this added

@stale stale bot closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants