feat: add missing properties to Elements
#130
Open
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hrueger is attempting to deploy a commit to the Joshua Nussbaum's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @hrueger, I'm working on an update to Svelte5, so it might be better to hold off on this until it's merged. |
|
Hi @joshnuss, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for the great job on this package! I was missing the
paymentMethodTypesproperty on theElementselement and thought that while I was at it, I could also just add all other possible properties.I also changed the allowed stripe sdk version to
5. I hope this did not break anything.Best
Hannes