Zero width in marginal pannels #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stigating this issue, I realized that setWidths function was using the method Math.floor. Since we expect that bw and fw will be lower, in some cases, when applying the Math.floor, the result is zero. So my suggestion is: 1) Use Math.round instead of Math.floor (it's more realistic). 2) Configure a min value (for instance, 5) to prevent these values beeing very low (and users cannot interact with them)
|
I agree. On small mobile devices I had a hard time getting the margins to register the touch event. I added your changes to the source files and also ended up changing the margins to improve the user experience. Now it works the way I expect it. |
TronFortyTwo
added a commit
to TronFortyTwo/sturmreader
that referenced
this pull request
Apr 28, 2020
Zero width in marginal pannels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my own tests, the width of marginal panels was always zero. Investigating this issue, I realized that setWidths function was using the method Math.floor. Since we expect that bw and fw will be lower in some cases, when applying the Math.floor, the result is zero.
So my suggestion is: