Import Decimal from decimal.js rather than decimal.mjs #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `decimal.js` package provides the decimal.js as well as decimal.mjs files. See: https://github.com/MikeMcl/decimal.js In certain webpack configurations, the decimal.mjs file is loaded, causing the error: ``` Uncaught TypeError: decimal_js__WEBPACK_IMPORTED_MODULE_0__.default.clone is not a function createBigNumberClass BigNumber.js:12 assertAndCreate factory.js:35 ``` When we are more specific with this import, this error is resolved.
|
Thanks for your PR Nikolas. In general, I would like to move code to ESM, and not to CommonJS/UMD, and use the regular import instead of pointing to a specific file. Can we figure out what is going wrong in your setup? Maybe we can come up with an other solution. How can I reproduce this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
decimal.jspackage provides the decimal.js as well as decimal.mjs files. See: https://github.com/MikeMcl/decimal.jsIn certain webpack configurations, the decimal.mjs file is loaded, causing the error:
When we are more specific with this import, this error is resolved.