-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ContenthistoryHelper to use absolute image paths #44645
base: 5.3-dev
Are you sure you want to change the base?
Conversation
My first PR and regarding issue joomla#44635
@Attila-SWE Thanks for your first PR. Please close the issue. I will test the PR but wan't to wait first if there is Feedback. |
Done! So if I understand correctly then first create issue, then create pull request referring to issue and close issue? Is there any "documentation" for this regarding Joomla that I could read up on? |
If you create a PR no Issue is needed. I don't know about Documentation for this workflow. |
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
@alikon Makes it sense to test the Pull Request as |
@fgsw drone is failing at Code style step |
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
Sorry for many small changes. First PR.
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yet another code style
sorry i didn't check before
NP! Thanks for helping me learn |
hoping is the last 1 for code syle
code style for your joomla#44645
My first PR so sorry if I messed something up. Please give me feedback then. Some considerations is that this only fixes images in images/ folder and does not fix other relative URL:s or such. Perhaps a broader fix is necessary?
Pull Request for Issue #44635.
Summary of Changes
Check to see if values in content history includes images with relative /images url
Testing Instructions
Open preview of content history with images in content with relative urls like images/test.png
Actual result BEFORE applying this Pull Request
Images broken because urls are relative to /administrator/ so for example DOMAIN/administrator/images/test.png
Expected result AFTER applying this Pull Request
Images shown and url of images is DOMAIN/images/test.png
Link to documentations
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed