Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary null check in cpaitalizeFirst and capitalize method #2849

Merged
merged 7 commits into from
Jul 17, 2023

Conversation

sumitsharansatsangi
Copy link
Contributor

  • Removing unneessary check results in null-exempt string .i. e. earlier return type was String? now it becomes String *

Every PR must update the corresponding documentation in the code, and also the readme in english with the following changes.

Pre-launch Checklist

  • [] I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Owner

@jonataslaw jonataslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonataslaw
Copy link
Owner

Thank you for your contribution!

@jonataslaw jonataslaw merged commit addfa3d into jonataslaw:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants