Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect query and required parameters #2848

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

tshedor
Copy link
Contributor

@tshedor tshedor commented Jul 15, 2023

The router doesn't include optional query-string parameters when required parameters are present.

For example, /route/:id and /route?id=1 are respected, but /route/:id/profile?title=dev only parses :id. This PR provides :id and title to Get.parameters

Pre-launch Checklist

  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
  • All existing and new tests are passing.

@jonataslaw
Copy link
Owner

Thank you for your contribution!
LGTM

@jonataslaw jonataslaw merged commit b8c2d8e into jonataslaw:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants