Random Vogon fixes

[vanam]

Hi,
firstly, I would like to thank you for this amazing demo.

There are several minor improvements which might make your demo one bit more amazing.

So Long, and Thanks for All the Fish

[vanam]

Strange thing happens when I run ./gradlew resolveAndLockAll --write-locks. Every time it messes up some org.jetbrains.kotlin dependencies.

It turns

org.jetbrains.kotlin:kotlin-stdlib-common:2.0.0=compileClasspath,productionRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.24=compileClasspath,productionRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24=compileClasspath,productionRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath

to

org.jetbrains.kotlin:kotlin-stdlib-common:2.0.0=compileClasspath,testCompileClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.24=compileClasspath,testCompileClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24=compileClasspath,testCompileClasspath

and then ./gradlew build fails:

Execution failed for task ':tea-service:cyclonedxBom'.
> Could not resolve all dependencies for configuration ':tea-service:runtimeClasspath'.
   > Resolved 'org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24' which is not part of the dependency lock state
   > Resolved 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.24' which is not part of the dependency lock state
   > Resolved 'org.jetbrains.kotlin:kotlin-stdlib-common:2.0.0' which is not part of the dependency lock state

I have to manualy remove this change from changelist. Is it also happening to you?

[jonatan-ivanov]

Thank you for the PR, I'm glad you like the project.
This PR does a lot of things, some I don't want to merge (right now/as-is) and some I would like to merge in but not all in one PR but separately.

If you don't want to open separate PRs (it's work), please let me know and I will cherry pick your commits and merge those separately.

[jonatan-ivanov]

Strange thing happens when I run ./gradlew resolveAndLockAll --write-locks. Every time it messes up some org.jetbrains.kotlin dependencies.
[...]
I have to manualy remove this change from changelist. Is it also happening to you?

Unfortunately it does, I think this is caused by okhttp that uses the Kotlin SDK, it's on my list to fix it, I created an issue to track it: #13
I'm not a fan of having the Kotlin SDK on the classpath anyways so this can mean replacing okhttp (maybe OpenFeign too) for the new Interface Clients in Spring Framework but I need to check if instrumentation works with the customizations I have and if there is Logbook support available.

[vanam]

I guess we can close this PR now.

[jonatan-ivanov]

Thank you very much!

[jonatan-ivanov]

Superseded by

• Upgrade to Gradle 8.9 #14
• Upgrade Gradle Wrapper Validation GH Action to v3 #15
• Double quote Docker Compose ports #16
• Fix log file names for Eureka and Spring Boot Admin #17
• Remove @EnableDiscoveryClient annotation #18

[jonatan-ivanov]

I think the merged PRs and these commits:

• e4a6cfa
• a84d86a
  should cover the changes in this PR, please let me know if this is not the case.

Thank you very much once again for the contributions!