-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpret :arglists using "regex" notation #399
Comments
Or, you know, Eastwood could use the actual declared argument list for arity checking, like |
I think we have the same thing in mind: my issue describes interpreting :arglists metadata smartly. |
Eastwood 0.9.7 silences all honeysql false positives for I'd still like to interpret the regexes more smartly in a future! |
:arglists can use a regex notation:,
?, *, +
e.g. https://github.com/clojure/clojure/blob/b1b88dd25373a86e41310a525a21b497799dbbf2/src/clj/clojure/core.clj#L7724-L7726Eastwood could make a best-effort at expanding these to
&
syntax (internally, non-mutatively) so that defns using such notation don't trigger :bad-arglists faults.Worst-case scenario, any fault coming from an :arglist using regex notation could be automatically omitted.
Finally, if implementing this we could remove
eastwood/resource/eastwood/config/clojure.clj
Lines 113 to 117 in 2e58aba
(note that
?
can more often than not will signal a boolean/predicate)The text was updated successfully, but these errors were encountered: