Skip to content

Commit 100f667

Browse files
committed
Silence :wrong-arity false positives for honeysql for now
See #399
1 parent 5901543 commit 100f667

File tree

2 files changed

+48
-1
lines changed

2 files changed

+48
-1
lines changed

changes.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,19 @@
22

33
#### New
44

5-
* Implement ability to omit a specific linter `:kind`
5+
* Implement ability to omit a specific linter `:kind`.
66
* Closes https://github.com/jonase/eastwood/issues/387
77
* [Documentation](https://github.com/jonase/eastwood#ignoring-linter-sub-kinds)
88
* Now the `:second-arg-is-not-string` sub-kind for the `:suspicious-test` is disabled by default.
99
* Rationale: https://github.com/jonase/eastwood/issues/387
1010
* You can re-enable it by passing `:exclude-linters #{}`
1111
* [Learn more about sub-kind silencing](https://github.com/jonase/eastwood#ignoring-linter-sub-kinds)
1212

13+
#### Bugfixes
14+
15+
* Silence `:wrong-arity` false positives for honeysql the time being.
16+
* Part of https://github.com/jonase/eastwood/issues/399
17+
1318
## Changes from 0.9.4 to 0.9.6
1419

1520
#### Bugfixes

resource/eastwood/config/third-party-libs.clj

+42
Original file line numberDiff line numberDiff line change
@@ -345,3 +345,45 @@
345345
{:linter :constant-test
346346
:if-inside-macroexpansion-of #{'spec-tools.core/spec
347347
'borkdude.dynaload/dynaload}})
348+
349+
(doseq [s '[honey.sql.helpers/add-index
350+
honey.sql.helpers/alter-table
351+
honey.sql.helpers/bulk-collect-into
352+
honey.sql.helpers/clause-or-expression
353+
honey.sql.helpers/create-extension
354+
honey.sql.helpers/create-materialized-view
355+
honey.sql.helpers/create-table
356+
honey.sql.helpers/create-table-as
357+
honey.sql.helpers/create-view
358+
honey.sql.helpers/delete
359+
honey.sql.helpers/delete-from
360+
honey.sql.helpers/do-nothing
361+
honey.sql.helpers/do-update-set
362+
honey.sql.helpers/drop-column
363+
honey.sql.helpers/fetch
364+
honey.sql.helpers/filter
365+
honey.sql.helpers/for
366+
honey.sql.helpers/insert-into
367+
honey.sql.helpers/into
368+
honey.sql.helpers/limit
369+
honey.sql.helpers/lock
370+
honey.sql.helpers/offset
371+
honey.sql.helpers/on-conflict
372+
honey.sql.helpers/on-constraint
373+
honey.sql.helpers/on-duplicate-key-update
374+
honey.sql.helpers/refresh-materialized-view
375+
honey.sql.helpers/rename-column
376+
honey.sql.helpers/rename-table
377+
honey.sql.helpers/select-distinct-on
378+
honey.sql.helpers/set
379+
honey.sql.helpers/truncate
380+
honey.sql.helpers/update
381+
honey.sql.helpers/values
382+
honey.sql.helpers/with-columns
383+
honey.sql.helpers/with-data
384+
honey.sql.helpers/within-group]]
385+
(disable-warning
386+
{:linter :wrong-arity
387+
:function-symbol s
388+
:arglists-for-linting '([& _])
389+
:reason "Eastwood is currently unable to parse honeysql-style arglists, see https://github.com/jonase/eastwood/issues/399"}))

0 commit comments

Comments
 (0)