Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batches to README.md #3330

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Add batches to README.md #3330

merged 2 commits into from
Oct 13, 2024

Conversation

Ranjana761
Copy link
Contributor

Added badges in README

@caco3 caco3 marked this pull request as draft October 11, 2024 19:23
@caco3
Copy link
Collaborator

caco3 commented Oct 11, 2024

Thanks fr your proposal.
How ever I have some remarks and questions about it:

  1. The project is based on C++, not Python. Python is only used to train the models, but that happens in separate repos.
  2. The release batch shows a non-existent version (1.1.1). Even when I load the svg directly, it shows this (hardcoded?) version: https://img.shields.io/github/v/release/Naereen/StrapDown.js.svg
  3. Also the other numbers (forks, downloads, stars) seem to be completely random!

@caco3 caco3 changed the title Update README.md Add batches to README.md Oct 11, 2024
@Ranjana761 Ranjana761 marked this pull request as ready for review October 13, 2024 06:57
@Ranjana761
Copy link
Contributor Author

Thanks fr your proposal. How ever I have some remarks and questions about it:

  1. The project is based on C++, not Python. Python is only used to train the models, but that happens in separate repos.
  2. The release batch shows a non-existent version (1.1.1). Even when I load the svg directly, it shows this (hardcoded?) version: https://img.shields.io/github/v/release/Naereen/StrapDown.js.svg
  3. Also the other numbers (forks, downloads, stars) seem to be completely random!

Done with changes.

@caco3 caco3 self-assigned this Oct 13, 2024
@jomjol jomjol merged commit 224e438 into jomjol:main Oct 13, 2024
6 checks passed
@caco3
Copy link
Collaborator

caco3 commented Oct 13, 2024

@jomjol That was a bit fast, the download counter is not correct yet.
@Ranjana761 Do you know why it is still wrong? Can we fix it somehow? It is supposed to be >25k!

-> I fixed it now myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants