Fix slack message in double #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
reviewed
Jul 18, 2019
src/Event/CfpEndingSoonEvent.php
Outdated
| @@ -41,25 +41,26 @@ public function buildAttachment(): array | |||
| $cfpAttachment = SlackNotifier::ATTACHMENT; | |||
| $template = '🔊 CFP for %s (%s) is closing %s'; | |||
| $conferenceLink = sprintf('<%s|%s>', $this->conference->getCfpUrl(), $this->conference->getName()); | |||
| $countdown = 'in *' . $this->remainingDays . ' day' . $this->remainingDays > 1 ? 's' : '' . '* !'; | |||
There was a problem hiding this comment.
pretty sure we can make this a lot cleaner and use translation plural syntax 😉
There was a problem hiding this comment.
Yes, it's mentioned in #47
welcoMattic
force-pushed
the
fix/slack-messages
branch
from
12c9e19 to
6435919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44