Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync recipes, run composer u and yarn upgrade, fix some deprecations #237

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

HedicGuibert
Copy link
Member

Dependancies and recipes where not completely up to date so this updates everything.

We still have a lot of deprecations however, beause of the php-translation bundle, which is still using deprecated code.
This should not be an issue anymore when we fix #221 (or when the library gets an update).

@HedicGuibert HedicGuibert added the RFR Ready for review label Sep 30, 2021
.gitignore Outdated Show resolved Hide resolved
@@ -46,14 +46,15 @@
"symfony/phpunit-bridge": "^5.3",
"symfony/polyfill-uuid": "^1.20",
"symfony/process": "5.3.*",
"symfony/runtime": "5.3.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it installed now?

Copy link
Member Author

@HedicGuibert HedicGuibert Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because of this PR : symfony/recipes@9a90e69

Symfony runtime is now a dependancy of the Symfony console.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(An issue already exists : symfony/recipes#992)

@lyrixx lyrixx merged commit 9755435 into master Oct 1, 2021
@lyrixx lyrixx deleted the recipes branch October 1, 2021 08:36
@lyrixx
Copy link
Member

lyrixx commented Oct 1, 2021

Thanks

@HedicGuibert HedicGuibert mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translations
3 participants