Merge pull request #98 from vesper8/patch-1

add -contentImage option to TerminalNotifier
jolicode · Apr 24, 2024 · 3963656 · 3963656
2 parents 18aa721 + 49eed58
commit 3963656
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Not released yet
 
 * Added wsl-notify-send notifier for Windows Subsystem for Linux
+* Changed TerminalNotifier to use contentImage option for icon instead of appIcon
 
 ## 2.6.0 (2023-12-03)
 

diff --git a/src/Notifier/TerminalNotifierNotifier.php b/src/Notifier/TerminalNotifierNotifier.php
@@ -43,7 +43,7 @@ protected function getCommandLineArguments(Notification $notification): array
         }
 
         if ($notification->getIcon() && version_compare(OsHelper::getMacOSVersion(), '10.9.0', '>=')) {
-            $arguments[] = '-appIcon';
+            $arguments[] = '-contentImage';
             $arguments[] = $notification->getIcon();
         }
 

diff --git a/tests/Notifier/TerminalNotifierNotifierTest.php b/tests/Notifier/TerminalNotifierNotifierTest.php
@@ -67,7 +67,7 @@ protected function getExpectedCommandLineForNotificationWithAnIcon(): string
             $iconDir = $this->getIconDir();
 
             return <<<CLI
-                'terminal-notifier' '-message' 'I'\\''m the notification body' '-appIcon' '{$iconDir}/image.gif'
+                'terminal-notifier' '-message' 'I'\\''m the notification body' '-contentImage' '{$iconDir}/image.gif'
                 CLI;
         }
 
@@ -82,7 +82,7 @@ protected function getExpectedCommandLineForNotificationWithAllOptions(): string
             $iconDir = $this->getIconDir();
 
             return <<<CLI
-                'terminal-notifier' '-message' 'I'\\''m the notification body' '-title' 'I'\\''m the notification title' '-appIcon' '{$iconDir}/image.gif' '-open' 'https://google.com'
+                'terminal-notifier' '-message' 'I'\\''m the notification body' '-title' 'I'\\''m the notification title' '-contentImage' '{$iconDir}/image.gif' '-open' 'https://google.com'
                 CLI;
         }