feat: handle errors

johnnyreilly · Jan 2, 2024 · 120842f · 120842f
1 parent c7af5a1
commit 120842f
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 23 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -34979,7 +34979,7 @@ ${responseText}`);
     }
 }
 function processValidationResult(validationResult) {
-    const seeMore = `For more details see https://validator.schema.org/#url=${encodeURIComponent(validationResult.url)}`;
+    const seeMore = seeMoreMaker(validationResult.url);
     if (validationResult.numObjects === 0) {
         return {
             success: false,
@@ -35006,6 +35006,9 @@ ${seeMore}
 `,
     };
 }
+function seeMoreMaker(url) {
+    return `For more details see https://validator.schema.org/#url=${encodeURIComponent(url)}`;
+}
 
 ;// CONCATENATED MODULE: ./src/main.ts
 
@@ -35017,13 +35020,24 @@ async function run() {
         const results = [];
         for (const url of urls) {
             console.log(`Validating ${url} for structured data...`);
-            const validationResult = processValidationResponse(await getValidationResponse(url));
-            const processedValidationResult = processValidationResult(validationResult);
-            results.push({
-                url,
-                // validationResult,
-                processedValidationResult,
-            });
+            try {
+                const validationResult = processValidationResponse(await getValidationResponse(url));
+                const processedValidationResult = processValidationResult(validationResult);
+                results.push({
+                    url,
+                    processedValidationResult,
+                });
+            }
+            catch (err) {
+                console.error(`Failed to validate ${url}`, err);
+                results.push({
+                    url,
+                    processedValidationResult: {
+                        success: false,
+                        resultText: `Failed to validate ${url}. ${seeMoreMaker(url)}`,
+                    },
+                });
+            }
         }
         core.setOutput("results", results);
         if (results.every((result) => result.processedValidationResult.success)) {

diff --git a/dist/main.d.ts.map b/dist/main.d.ts.map
diff --git a/dist/validate.d.ts b/dist/validate.d.ts
@@ -3,3 +3,4 @@ import { type ValidationResult } from "./validationResult.js";
 export declare function getValidationResponse(url: string): Promise<string>;
 export declare function processValidationResponse(responseText: string): ValidationResult;
 export declare function processValidationResult(validationResult: ValidationResult): ProcessedValidationResult;
+export declare function seeMoreMaker(url: string): string;
diff --git a/dist/validate.d.ts.map b/dist/validate.d.ts.map
diff --git a/src/main.ts b/src/main.ts
@@ -3,6 +3,7 @@ import {
 	processValidationResult,
 	processValidationResponse,
 	getValidationResponse,
+	seeMoreMaker,
 } from "./validate.js";
 import type { Result } from "./validationResult.js";
 
@@ -15,17 +16,27 @@ export async function run(): Promise<void> {
 		for (const url of urls) {
 			console.log(`Validating ${url} for structured data...`);
 
-			const validationResult = processValidationResponse(
-				await getValidationResponse(url),
-			);
-			const processedValidationResult =
-				processValidationResult(validationResult);
+			try {
+				const validationResult = processValidationResponse(
+					await getValidationResponse(url),
+				);
+				const processedValidationResult =
+					processValidationResult(validationResult);
 
-			results.push({
-				url,
-				// validationResult,
-				processedValidationResult,
-			});
+				results.push({
+					url,
+					processedValidationResult,
+				});
+			} catch (err) {
+				console.error(`Failed to validate ${url}`, err);
+				results.push({
+					url,
+					processedValidationResult: {
+						success: false,
+						resultText: `Failed to validate ${url}. ${seeMoreMaker(url)}`,
+					},
+				});
+			}
 		}
 
 		core.setOutput("results", results);

diff --git a/src/validate.ts b/src/validate.ts
@@ -75,9 +75,7 @@ ${responseText}`,
 export function processValidationResult(
 	validationResult: ValidationResult,
 ): ProcessedValidationResult {
-	const seeMore = `For more details see https://validator.schema.org/#url=${encodeURIComponent(
-		validationResult.url,
-	)}`;
+	const seeMore = seeMoreMaker(validationResult.url);
 
 	if (validationResult.numObjects === 0) {
 		return {
@@ -109,3 +107,9 @@ ${seeMore}
 `,
 	};
 }
+
+export function seeMoreMaker(url: string) {
+	return `For more details see https://validator.schema.org/#url=${encodeURIComponent(
+		url,
+	)}`;
+}