style: apply Biome formatting to hook templates #30
Conversation
- Format TypeScript imports to use consistent style - Apply spacing and formatting rules to match project standards - Update VS Code settings for Biome formatter configuration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
WalkthroughA new local JSON configuration for Bash command permissions is introduced. VSCode settings are updated to use Biome as the default formatter and enable format-on-save. Imports in the Changes
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.claude/settings.local.json (1)
1-18: LGTM! Well-structured permissions configuration.The permissions policy appropriately allows essential development commands while maintaining security through explicit allowlisting. The configuration aligns well with the project's tooling needs (git, bun, GitHub CLI, biome formatter).
Consider adding a comment at the top of the file documenting the purpose and structure of the permissions policy for future maintainers:
+{ + // Local permissions for Claude hooks - allows specific bash commands + // Format: "Bash(command:*)" where * allows parameters { "permissions": {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.claude/settings.local.json(1 hunks).vscode/settings.json(1 hunks)templates/hooks/index.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
templates/**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: johnlindquist/claude-hooks#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-07T16:54:50.723Z
Learning: Applies to package.json : The project must use ESM modules (package.json must include '"type": "module"').
Learnt from: CR
PR: johnlindquist/claude-hooks#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-07T16:54:50.723Z
Learning: Applies to .claude/{settings.json,hooks/index.ts,hooks/lib.ts,hooks/session.ts} : The CLI generates a '.claude/' directory containing 'settings.json', 'hooks/index.ts', 'hooks/lib.ts', and 'hooks/session.ts' when initialized.
Learnt from: CR
PR: johnlindquist/claude-hooks#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-07T16:54:50.723Z
Learning: Applies to tsconfig.json : TypeScript strict mode must be enabled.
templates/hooks/index.ts (2)
Learnt from: CR
PR: johnlindquist/claude-hooks#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-07T16:54:50.723Z
Learning: Applies to .claude/{settings.json,hooks/index.ts,hooks/lib.ts,hooks/session.ts} : The CLI generates a '.claude/' directory containing 'settings.json', 'hooks/index.ts', 'hooks/lib.ts', and 'hooks/session.ts' when initialized.
Learnt from: CR
PR: johnlindquist/claude-hooks#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-07T16:54:50.723Z
Learning: Hooks are executed using the Bun runtime, which is a required dependency.
.claude/settings.local.json (1)
Learnt from: CR
PR: johnlindquist/claude-hooks#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-07T16:54:50.723Z
Learning: Applies to .claude/{settings.json,hooks/index.ts,hooks/lib.ts,hooks/session.ts} : The CLI generates a '.claude/' directory containing 'settings.json', 'hooks/index.ts', 'hooks/lib.ts', and 'hooks/session.ts' when initialized.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test (macos-latest, 20)
- GitHub Check: test (windows-latest, 18)
- GitHub Check: test (windows-latest, 20)
- GitHub Check: test (ubuntu-latest, 18)
🔇 Additional comments (2)
templates/hooks/index.ts (1)
3-12: LGTM! Excellent TypeScript import formatting.The refactoring to separate type imports from value imports is a modern TypeScript best practice that improves code clarity and aligns with Biome formatter standards. This change enhances readability without affecting functionality.
.vscode/settings.json (1)
11-22: LGTM! Excellent Biome formatter configuration.The VSCode settings perfectly align with the PR objectives by:
- Setting Biome as the default formatter globally and for specific file types
- Enabling format-on-save for automatic consistency
- Ensuring all team members use the same formatting standards
This configuration will significantly improve code consistency across the project.
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Refactor