fix: get hook_type from process.argv[2] instead of payload #10

johnlindquist · 2025-07-04T00:11:13Z

Summary

Modified runHook function to get hook_type from process.argv[2]
The hook_type is now added to the payload object
This allows Claude to pass the hook type via CLI arguments rather than requiring it in the JSON payload

Test plan

✅ Tested PreToolUse hook with safe commands
✅ Tested PreToolUse hook blocks dangerous commands (rm -rf)
✅ Tested Notification hook
✅ Verified session files are created with correct hook_type
✅ All hooks work without hook_type in the input JSON

🤖 Generated with Claude Code

Summary by CodeRabbit

Refactor
- Improved internal handling of hook type determination for more consistent behavior. No changes to user-facing features.

The hook_type is now properly retrieved from command line arguments (process.argv[2]) and added to the payload, allowing Claude to pass the hook type via CLI rather than requiring it in the JSON payload. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

coderabbitai · 2025-07-04T00:11:20Z

Caution

Review failed

The pull request is closed.

Walkthrough

The runHook function in templates/hooks/lib.ts was updated to determine the hook type from the command-line argument (process.argv[2]) instead of the input JSON. The function now constructs the payload with this extracted hook type before dispatching to the appropriate handler. No changes were made to exported function signatures.

Changes

File(s)	Change Summary
templates/hooks/lib.ts	Modified `runHook` to extract hook type from command-line arguments and use it in the payload.

Poem

A hook hops in, with arguments in tow,
No longer from JSON does the hook type flow.
From command-line whispers, the truth it now seeks,
Dispatching with clarity, no more mystique.
The code is more certain, the rabbit approves—
Onward with hooks, as the project improves! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73ec81d and 91a486c.

📒 Files selected for processing (1)

templates/hooks/lib.ts (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## [1.1.2](v1.1.1...v1.1.2) (2025-07-04) ### Bug Fixes * get hook_type from process.argv[2] instead of payload ([#10](#10)) ([06a7210](06a7210))

github-actions · 2025-07-04T00:12:09Z

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

johnlindquist merged commit 06a7210 into main Jul 4, 2025
8 of 10 checks passed

github-actions bot pushed a commit that referenced this pull request Jul 4, 2025

chore(release): 1.1.2 [skip ci]

4b524db

## [1.1.2](v1.1.1...v1.1.2) (2025-07-04) ### Bug Fixes * get hook_type from process.argv[2] instead of payload ([#10](#10)) ([06a7210](06a7210))

github-actions bot added the released label Jul 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: get hook_type from process.argv[2] instead of payload #10

fix: get hook_type from process.argv[2] instead of payload #10

Uh oh!

johnlindquist commented Jul 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 4, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: get hook_type from process.argv[2] instead of payload #10

fix: get hook_type from process.argv[2] instead of payload #10

Uh oh!

Conversation

johnlindquist commented Jul 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

johnlindquist commented Jul 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)