Skip to content

Conversation

@johnlindquist
Copy link
Owner

@johnlindquist johnlindquist commented Jul 3, 2025

  • Remove ESLint and all related dependencies
  • Add Biome v2.0.6 with configuration matching existing Prettier settings
  • Update package.json scripts to use Biome commands
  • Create .biomeignore for excluding generated files
  • Apply Biome formatting to all source files

🤖 Generated with Claude Code

Description

Brief description of the changes in this PR.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Related Issues

Closes #(issue number)

Testing

  • All tests pass locally
  • Added new tests for changes
  • Test coverage maintained or improved
  • Manual testing completed

Test Results

npm test
# Paste test output here

Coverage Report

npm run test:coverage
# Paste coverage summary here

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Add screenshots to help explain your changes.

Additional Notes

Any additional information that reviewers should know.

Summary by CodeRabbit

  • Chores

    • Migrated from ESLint to Biome for code linting and formatting, updating configuration files and scripts accordingly.
    • Removed ESLint configuration and dependencies.
    • Added a Biome configuration file with custom formatting and linting rules.
    • Updated ignore patterns to exclude additional files from processing.
  • Style

    • Standardized code formatting across the project, including consistent indentation and removal of extra spaces in import statements and objects. No functional changes were made.

- Remove ESLint and all related dependencies
- Add Biome v2.0.6 with configuration matching existing Prettier settings
- Update package.json scripts to use Biome commands
- Create .biomeignore for excluding generated files
- Apply Biome formatting to all source files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jul 3, 2025

Warning

Rate limit exceeded

@johnlindquist has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 801e44a and 74367bf.

📒 Files selected for processing (2)
  • biome.json (1 hunks)
  • package.json (2 hunks)

Walkthrough

This update replaces ESLint with Biome for linting and formatting, introducing a new biome.json configuration and updating related scripts and ignore files. The .vscode/settings.json file's indentation is standardized. Multiple files receive stylistic formatting changes, mainly removing spaces inside braces in imports and exports, without altering logic or functionality.

Changes

File(s) Change Summary
biome.json Added new Biome configuration file specifying formatting, linting, and assist rules.
.biomeignore Added oclif.manifest.json to ignore patterns.
eslint.config.mjs Removed ESLint configuration file and its exports.
package.json Replaced ESLint dependencies/scripts with Biome; added format/lint:fix scripts.
.vscode/settings.json Reformatted indentation from 4 to 2 spaces; no content changes.
bin/dev.js, bin/run.js Removed spaces inside import braces and argument objects; no logic changes.
src/commands/init.ts, src/index.ts Removed spaces in import/export braces and destructuring; formatting only.
templates/hooks/lib.ts Removed spaces in JSON.stringify and options objects; formatting only.
test/commands/init.test.ts, test/integration/cli.test.ts, Reformatted imports and destructuring; added trailing comma in one assertion.
test/smoke/generated-files.test.ts, test/helpers/index.ts Reformatted imports and parameter object closing brace; formatting only.

Poem

A hop, a skip, a tidy sweep,
Biome now keeps our code so neat!
ESLint’s gone, the scripts are new,
Braces snug, and spaces few.
With every check and every run,
This rabbit’s work is never done—
But oh, how lovely things now look!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
package.json (1)

18-23: Remove obsolete Prettier config dev-dependency

With ESLint & Prettier now gone, @oclif/prettier-config is dead weight. It pulls in Prettier transitively and re-adds ~22 MB of node-modules bloat.

@@
-    "@oclif/prettier-config": "^0.2.1",
🧹 Nitpick comments (2)
package.json (1)

70-72: Script names overlap — consolidate lint vs format

lint:fix (biome check --write) and format (biome format --write) both mutate files. Keeping both can confuse contributors.

Consider one of:

  1. Keep lint & lint:fix, drop format.
  2. Rename format to format:check (read-only) and let lint:fix be the mutating command.

Either path avoids duplicate responsibilities.

biome.json (1)

31-42: Type-safety rules turned off—double-check intent

noExplicitAny and noNonNullAssertion are disabled (off). While this reduces noise, it also silences two of the most common sources of TypeScript runtime bugs.

If the goal is to ease migration noise, consider downgrading them to "warn" instead of disabling entirely so issues are still surfaced in CI without blocking local dev.

-        "noNonNullAssertion": "off",
+        "noNonNullAssertion": "warn",
 ...
-        "noExplicitAny": "off"
+        "noExplicitAny": "warn"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33e6dc3 and 801e44a.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (14)
  • .biomeignore (1 hunks)
  • .vscode/settings.json (1 hunks)
  • bin/dev.js (1 hunks)
  • bin/run.js (1 hunks)
  • biome.json (1 hunks)
  • eslint.config.mjs (0 hunks)
  • package.json (2 hunks)
  • src/commands/init.ts (2 hunks)
  • src/index.ts (1 hunks)
  • templates/hooks/lib.ts (2 hunks)
  • test/commands/init.test.ts (3 hunks)
  • test/helpers/index.ts (1 hunks)
  • test/integration/cli.test.ts (1 hunks)
  • test/smoke/generated-files.test.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • eslint.config.mjs
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test (windows-latest, 20)
  • GitHub Check: test (windows-latest, 18)
🔇 Additional comments (12)
.biomeignore (1)

8-9: Addition aligns ignore list with new Biome workflow

Ignoring templates/ and the generated oclif.manifest.json prevents Biome from wasting cycles on build artefacts. Looks good.

test/integration/cli.test.ts (1)

1-4: Import-brace whitespace tweak is purely stylistic

No behavioural impact; consistent with Biome’s formatting rules.

test/smoke/generated-files.test.ts (1)

1-4: Formatting change only

Brace-space removal matches the new formatter; no action needed.

src/index.ts (1)

1-2: Export line re-formatted correctly

Whitespace removal is stylistic; module surface remains unchanged.

.vscode/settings.json (1)

2-28: Indentation switched to 2-space – matches Biome config

Settings content unchanged; consistent project-wide formatting.

src/commands/init.ts (2)

2-3: Formatting-only adjustment looks good
No functional impact; complies with the new Biome style.


40-40: Destructuring spacing change is fine
Purely stylistic; logic remains intact.

bin/dev.js (1)

3-5: CLI entry-point formatting update accepted
Whitespace removal around braces/args aligns with Biome rules; runtime behaviour unchanged.

test/helpers/index.ts (1)

32-42: Signature formatting tweak acknowledged
Only moves the closing brace/comma; tests remain unaffected.

templates/hooks/lib.ts (1)

66-66: Consistent JSON stringify spacing – OK
Uniform object-literal spacing is now enforced; no behavioural differences.

Also applies to: 114-146

test/commands/init.test.ts (1)

1-5: Imports & assertion formatting updated correctly
All changes are cosmetic; tests still convey the same assertions.

Also applies to: 28-28, 172-173

bin/run.js (1)

3-3: Formatting-only changes look good

Pure whitespace/spacing tweaks driven by the new Biome config. Nothing functional changed. 👍

Also applies to: 11-11

johnlindquist and others added 2 commits July 3, 2025 22:22
Remove explicit lineEnding setting to allow automatic detection
on different platforms (LF on Unix, CRLF on Windows)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Windows Git checkouts use CRLF line endings by default, which conflicts
with Biome's formatting expectations. Skip the posttest lint step on
Windows platforms to allow tests to pass in CI.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@johnlindquist johnlindquist merged commit 63328a9 into main Jul 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants