-
Notifications
You must be signed in to change notification settings - Fork 11
Replace ESLint with Biome for linting and formatting #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove ESLint and all related dependencies - Add Biome v2.0.6 with configuration matching existing Prettier settings - Update package.json scripts to use Biome commands - Create .biomeignore for excluding generated files - Apply Biome formatting to all source files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Warning Rate limit exceeded@johnlindquist has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 25 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis update replaces ESLint with Biome for linting and formatting, introducing a new Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
package.json (1)
18-23: Remove obsolete Prettier config dev-dependencyWith ESLint & Prettier now gone,
@oclif/prettier-configis dead weight. It pulls in Prettier transitively and re-adds ~22 MB of node-modules bloat.@@ - "@oclif/prettier-config": "^0.2.1",
🧹 Nitpick comments (2)
package.json (1)
70-72: Script names overlap — consolidate lint vs format
lint:fix(biome check --write) andformat(biome format --write) both mutate files. Keeping both can confuse contributors.Consider one of:
- Keep
lint&lint:fix, dropformat.- Rename
formattoformat:check(read-only) and letlint:fixbe the mutating command.Either path avoids duplicate responsibilities.
biome.json (1)
31-42: Type-safety rules turned off—double-check intent
noExplicitAnyandnoNonNullAssertionare disabled (off). While this reduces noise, it also silences two of the most common sources of TypeScript runtime bugs.If the goal is to ease migration noise, consider downgrading them to
"warn"instead of disabling entirely so issues are still surfaced in CI without blocking local dev.- "noNonNullAssertion": "off", + "noNonNullAssertion": "warn", ... - "noExplicitAny": "off" + "noExplicitAny": "warn"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (14)
.biomeignore(1 hunks).vscode/settings.json(1 hunks)bin/dev.js(1 hunks)bin/run.js(1 hunks)biome.json(1 hunks)eslint.config.mjs(0 hunks)package.json(2 hunks)src/commands/init.ts(2 hunks)src/index.ts(1 hunks)templates/hooks/lib.ts(2 hunks)test/commands/init.test.ts(3 hunks)test/helpers/index.ts(1 hunks)test/integration/cli.test.ts(1 hunks)test/smoke/generated-files.test.ts(1 hunks)
💤 Files with no reviewable changes (1)
- eslint.config.mjs
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test (windows-latest, 20)
- GitHub Check: test (windows-latest, 18)
🔇 Additional comments (12)
.biomeignore (1)
8-9: Addition aligns ignore list with new Biome workflowIgnoring
templates/and the generatedoclif.manifest.jsonprevents Biome from wasting cycles on build artefacts. Looks good.test/integration/cli.test.ts (1)
1-4: Import-brace whitespace tweak is purely stylisticNo behavioural impact; consistent with Biome’s formatting rules.
test/smoke/generated-files.test.ts (1)
1-4: Formatting change onlyBrace-space removal matches the new formatter; no action needed.
src/index.ts (1)
1-2: Export line re-formatted correctlyWhitespace removal is stylistic; module surface remains unchanged.
.vscode/settings.json (1)
2-28: Indentation switched to 2-space – matches Biome configSettings content unchanged; consistent project-wide formatting.
src/commands/init.ts (2)
2-3: Formatting-only adjustment looks good
No functional impact; complies with the new Biome style.
40-40: Destructuring spacing change is fine
Purely stylistic; logic remains intact.bin/dev.js (1)
3-5: CLI entry-point formatting update accepted
Whitespace removal around braces/args aligns with Biome rules; runtime behaviour unchanged.test/helpers/index.ts (1)
32-42: Signature formatting tweak acknowledged
Only moves the closing brace/comma; tests remain unaffected.templates/hooks/lib.ts (1)
66-66: Consistent JSON stringify spacing – OK
Uniform object-literal spacing is now enforced; no behavioural differences.Also applies to: 114-146
test/commands/init.test.ts (1)
1-5: Imports & assertion formatting updated correctly
All changes are cosmetic; tests still convey the same assertions.Also applies to: 28-28, 172-173
bin/run.js (1)
3-3: Formatting-only changes look goodPure whitespace/spacing tweaks driven by the new Biome config. Nothing functional changed. 👍
Also applies to: 11-11
Remove explicit lineEnding setting to allow automatic detection on different platforms (LF on Unix, CRLF on Windows) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Windows Git checkouts use CRLF line endings by default, which conflicts with Biome's formatting expectations. Skip the posttest lint step on Windows platforms to allow tests to pass in CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with Claude Code
Description
Brief description of the changes in this PR.
Type of Change
Related Issues
Closes #(issue number)
Testing
Test Results
Coverage Report
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Any additional information that reviewers should know.
Summary by CodeRabbit
Chores
Style