drhuffman12/enable_android_non_get_downloads #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostUnsupportedMessageHtml should be Deprecated.
|
Hey, thanks for the PR and sorry it's taken so long to get back to you! I'll need to look into this a little bit more. Given your point about Platform Versions I wouldn't want to break anyone less than 8 (which unfortunately, how most of the manufacturers treat android, is the predominant version...) I wonder if there is a way to detect in user agent and get the best of both worlds.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is time for
androidPostUnsupportedMessageHtmlto be deprecated. Non-get Downloads work in newer Chrome browsers for Android (at least Android 8); I'm guessing other browsers and less recent Android OS versions. Larger-scale testing should be done to confirm and weighed against Platform versions.