Use isinstance instead of type() ==

johannaengland · Aug 28, 2024 · 3f768be · 3f768be
1 parent 3026451
commit 3f768be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/tests/integration/snmptrapd_test.py b/tests/integration/snmptrapd_test.py
@@ -36,7 +36,7 @@ def test_plugin_loader_reading_in_modules_from_config_file():
     config.read(configfile)
     list_from_config = config.get('snmptrapd', 'handlermodules').split(',')
 
-    assert type(list_from_config) == list
+    assert isinstance(list_from_config, list)
     if len(list_from_config) <= 0:
         pytest.skip(
             "Requires at least one plugin in snmptrapd.conf to run"

diff --git a/tests/unittests/netmap/metadata_nx_test.py b/tests/unittests/netmap/metadata_nx_test.py
@@ -31,8 +31,7 @@ def _get_metadata(self, node_a, node_b, metadata_key='metadata'):
     def test_metadata_contains_edge_objects(self):
         for node_a, node_b, metadata in self.netmap_graph.edges(data=True):
             for pair in metadata.get('metadata'):
-                assert type(pair) == Edge
-                assert type(pair) == Edge
+                assert isinstance(pair, Edge)
 
     def test_node_a1_and_b1_contains_vlan_metadata(self):
         vlans = self.netmap_graph.nodes[self.a]['metadata']['vlans']