-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pickle DB Backend Support #37
base: main
Are you sure you want to change the base?
Conversation
Is error handling done right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Apart from the unused variant, I think the error handling is right, in the sense that it follows the current convention of the other backends. We might want to revisit that though, but not in this PR.
There are some whitespace formatting issues, most of them should go away by running cargo fmt
, but the toml ones you'll have to fix manually.
Other than that, it looks great to me :)
Are the tests passing locally for you? |
yes they are passing |
Hmm.. okay. We need to figure out why they are failing in ci, then. Which os are you on? |
Okay i tried on windows, passing there as well. Maybe it's some parent directory that needs to be created or something? What happens if you delete the app folder? Do the tests fail then? Guess i could try this myself, but on the go now |
hey i think dump function is causing error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think pickledb is a really good fit for a new default backend on native... but we need to fix that test. If anyone has the time to look into it, it would be much appreciated!
@johanhelsing I looked into pickledb source code, I might be wrong but it seems it loads the whole DB into memory which is a huge blocker for me to use. |
Ah, bummer. In either case, I don't plan on getting rid of the other backends. Other suggestions for maintained rust-only native backends are welcome. |
hey I think its better to close this PR as redb support was added |
This adds support for Pickle DB alternative backend for non-wasm based environments.
#32