Skip to content

Commit

Permalink
Improve the note about the absence of clear target type definition
Browse files Browse the repository at this point in the history
  • Loading branch information
joffrey-bion committed Feb 7, 2025
1 parent 240d274 commit 431f6da
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ if the attached target supports a given domain.
For instance, `PageSession.dom` gives access to the DOM domain in this page session, which allows to issue commands
and listen to DOM events.

> Note: The supported set of domains for each target type is not clearly defined by the protocol, so I have to
> regularly extract this information from
> [Chromium's source code itself](https://source.chromium.org/search?q=%22session-%3ECreateAndAddHandler%22%20f:devtools&ss=chromium)
> and update my own extra definition file: [target_types.json](protocol-definition/target_types.json).
> Note: The supported set of domains for each target type is
> [not clearly defined](https://github.com/ChromeDevTools/devtools-protocol/issues/311) by the protocol, so I have to
> regularly extract this information from Chromium's source code and update my own extra definition file:
> [target_types.json](protocol-definition/target_types.json).
> This process is described in details in a dedicated [README](protocol-definition/README.md).
>
> Because of this, there might be some missing domains on some session types at some point in time that require
> manual adjustment.
Expand Down

0 comments on commit 431f6da

Please sign in to comment.