Fix IsBetween method in TimeExtensions.cs

[drippypop]

This pull request addresses an issue with the IsBetween method in the TimeExtensions class. The current implementation does not correctly handle the case where startTime and endTime are equal. This fix adds a specific condition check to ensure accurate results.

Changes:

• Updated the IsBetween method to handle the case where startTime and endTime are equal.

Before:

public static bool IsBetween(this DateTime dateTime, Time startTime, Time endTime)
{
    var currentTime = dateTime.TimeOfTheDay();
    // Start time is lesser or equal than end time
    if (startTime.CompareTo(endTime) <= 0) {
        // CurrentTime should be between start time and end time
        if (currentTime.CompareTo(startTime) >= 0 && currentTime.CompareTo(endTime) <= 0) {
            return true;
        }
        return false;
    } else {
        // CurrentTime should be between end time and start time
        if (currentTime.CompareTo(startTime) >= 0 || currentTime.CompareTo(endTime) <= 0) {
            return true;
        }
        return false;
    }
}

After:

public static bool IsBetween(this DateTime dateTime, Time startTime, Time endTime)
{
    var currentTime = dateTime.TimeOfTheDay();
    // If startTime and endTime are equal
    if (startTime.Equals(endTime)) {
        if (currentTime.CompareTo(startTime) >= 0 && currentTime.CompareTo(endTime) <= 0) {
            return true;
        }
    }
    // Start time is lesser or equal than end time
    if (startTime.CompareTo(endTime) <= 0) {
        // CurrentTime should be between start time and end time
        if (currentTime.CompareTo(startTime) >= 0 && currentTime.CompareTo(endTime) <= 0) {
            return true;
        }
        return false;
    } else {
        // CurrentTime should be between end time and start time
        if (currentTime.CompareTo(startTime) >= 0 || currentTime.CompareTo(endTime) <= 0) {
            return true;
        }
        return false;
    }
}

Testing:

• Added unit tests to cover the new condition where startTime and endTime are equal.
• Verified that all existing tests pass.

Related Issues:

• Fixes Handling Equal Start and End Times in IsBetween Method #152

[joaomatossilva]

Added unit tests to cover the new condition where startTime and endTime are equal.

no tests on the PR