Manual Posix timezone string support to allow offline Clockwise clock #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffWDH
changed the title
jnthas
reviewed
Jul 21, 2023
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the ezTime library is used by Clockwise forces the clock to have Internet access to the ezTime timezone service to obtain the Posix timezone string. This PR adds an optional setting that allows you to specify your own string manually and allows the clock to work 100% offline using your own local NTP server.
Additionally, a list of timezones and their respective Posix strings is included with this. (PosixTimezoneStrings.txt)
Solves #39.