Use tricks to improve module visibility issues #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When open access to java.io is not granted to jnr-posix, display a warning about the APIs that will be broken. When open access is granted but jnr-posix is in the unnamed module, explicitly open the packages to eliminate the warnings. See https://github.com/jnr/jnr-posix/wiki/Using-jnr%E2%80%90posix-with-Java-Modules Eliminates warnings from unnamed module open access requests on releases prior to Java 17 and provides better information (with link to the above wiki page) on Java 17+ for unnamed modules or when open access is denied to the jnr-posix module. See discussion in #190
headius
force-pushed
the
better_module_handling
branch
from
3a4e801
to
7e6ac00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When open access to java.io is not granted to jnr-posix, display a warning about the APIs that will be broken.
When open access is granted but jnr-posix is in the unnamed module, explicitly open the packages to eliminate the warnings.
See https://github.com/jnr/jnr-posix/wiki/Using-jnr%E2%80%90posix-with-Java-Modules
Eliminates warnings from unnamed module open access requests on releases prior to Java 17 and provides better information (with link to the above wiki page) on Java 17+ for unnamed modules or when open access is denied to the jnr-posix module.
See discussion in #190