Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make get_next/get_prev mor generic such that borrowed forms of keys can be used #77

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mlgiraud
Copy link
Contributor

Title is self explanatory. If possible, it would be nice to have a small bugfix release for this. The change should be fully backwards compatible.

@coveralls
Copy link

Coverage Status

coverage: 84.176% (+0.1%) from 84.074%
when pulling 7411260 on mlgiraud:feat/borrowed_keys
into 2398556 on jneem:main.

@jneem
Copy link
Owner

jneem commented Apr 16, 2024

Thanks for the PR! I'm not sure about it being fully backwards-compatible, because if someone calls set.get_prev(x.into()) then type inference could fail with the new signature. (cargo semver-checks doesn't complain, but it also doesn't complain if I change the argument type to usize, so I think it's just incomplete in this case)

That said, I don't have any objection to bumping the version number.

@jneem jneem merged commit fd4e350 into jneem:main Apr 16, 2024
16 checks passed
@jneem
Copy link
Owner

jneem commented Apr 28, 2024

It took me a while, sorry, but this is now in 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants