output panel fixes

jmshrv · Jan 18, 2025 · ecefaef · ecefaef
1 parent 4052f47
commit ecefaef
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/lib/components/PlayerScreen/output_panel.dart b/lib/components/PlayerScreen/output_panel.dart
@@ -92,7 +92,7 @@ Future<void> showOutputMenu({
                 padding: const EdgeInsets.only(top: 6.0, bottom: 16.0),
                 child: Center(
                   child: Text(
-                      AppLocalizations.of(context)!.addRemoveFromPlaylist,
+                      AppLocalizations.of(context)!.outputMenuTitle,
                       style: TextStyle(
                           color: Theme.of(context).textTheme.bodyLarge!.color!,
                           fontSize: 18,
@@ -106,7 +106,8 @@ Future<void> showOutputMenu({
             header: Padding(
               padding: const EdgeInsets.only(
                   top: 10.0, bottom: 8.0, left: 16.0, right: 16.0),
-              child: Text("Available Outputs",
+              child: Text(
+                  AppLocalizations.of(context)!.outputMenuVolumeSectionTitle,
                   style: Theme.of(context).textTheme.titleMedium),
             ),
             sliver: MenuMask(
@@ -120,7 +121,8 @@ Future<void> showOutputMenu({
             header: Padding(
               padding: const EdgeInsets.only(
                   top: 10.0, bottom: 8.0, left: 16.0, right: 16.0),
-              child: Text("Available Outputs",
+              child: Text(
+                  AppLocalizations.of(context)!.outputMenuDevicesSectionTitle,
                   style: Theme.of(context).textTheme.titleMedium),
             ),
             sliver: MenuMask(
@@ -468,6 +470,7 @@ class _VolumeSliderState extends ConsumerState<VolumeSlider> {
                   "${(currentValue * 100).round()}%",
                   style: Theme.of(context).textTheme.bodyLarge?.copyWith(
                         fontWeight: FontWeight.w600,
+                        color: Colors.white,
                       ),
                 ),
               ),

diff --git a/lib/l10n/app_en.arb b/lib/l10n/app_en.arb
@@ -1845,5 +1845,17 @@
   "genericCancel": "Cancel",
   "@genericCancel": {
     "description": "Used when the user stops an action from taking place inside a popup dialog window"
+  },
+  "outputMenuTitle": "Change Output",
+  "@outputMenuTitle": {
+    "description": "Title for the output menu that allows the user to change the audio output device and volume"
+  },
+  "outputMenuVolumeSectionTitle": "Volume",
+  "@outputMenuVolumeSectionTitle": {
+    "description": "Title for the volume section in the output menu"
+  },
+  "outputMenuDevicesSectionTitle": "Available Devices",
+  "@outputMenuDevicesSectionTitle": {
+    "description": "Title for the available devices section in the output menu"
   }
 }
diff --git a/lib/screens/player_screen.dart b/lib/screens/player_screen.dart
@@ -437,7 +437,6 @@ class _PlayerScreenContent extends ConsumerWidget {
               Flexible(
                 fit: FlexFit.tight,
                 child: SimpleButton(
-                  inactive: !isLyricsAvailable,
                   text: "Output",
                   icon: TablerIcons.device_speaker,
                   onPressed: () async {