-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor python issues resolved #94
base: master
Are you sure you want to change the base?
Conversation
Thanks for this.
|
as these are already committed in my branch and about to be pushed ...
…s=True in JVM start, as per PR #94
Hmmm - it seems that me pushing my changes first was the wrong option, because it looks like it needs a rebase at your end now? Simon can you take a look and see if a merge and push at your end allows be to accept this again? |
The reason it is not recommended is that it forces all strings to Python even if they are just passing through which is slow and loses the expected Java methods. If you have a larg list of strings string and you are going to just check if it each ends in dot, then that is a big waste of lime converting. For reuseable modules that are meant to work with others convertStrings should be false. For a standalone program it is up to programmer to decide. The issue isnt so much JPype as Python as strings are forced to be concrete. If they were abstract then they could be both a Python and Java string at the same time and only have lazy conversion on the first use. The original JPype 0.6 was converting all which was found to be a problem, so the recommended and default behavior were switched. |
The file was removed from the working tree, but I simply restored the one I pushed. Should work now I hope! |
There are some minor issues with the example python codes:
numpy.int()
instead of the suggested native pythonint