docs: improve description of different completion scripts #7334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
approved these changes
Aug 23, 2025
There was a problem hiding this comment.
This looks like an improvement to me as-is, but perhaps we can go even further (see my other comments)? I'm not aware of any serious options with dynamic completions, and I'd probably recommend most packagers use those.
All of my comments could also be left for a separate PR or a separate discussion, if you prefer.
|
The dynamic completion offers a much better experience to the jj users, so this PR is a nice enhancement! |
martinvonz
approved these changes
Sep 3, 2025
|
Thanks for the ping, Gaetan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)