working_copy: Add WorkingCopyStateError conversions for ergonomics
#7280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuffix
force-pushed
the
push-tsyxmzqxyppy
branch
from
94a3c26 to
2396e7e
Compare
martinvonz
reviewed
Aug 18, 2025
isuffix
force-pushed
the
push-tsyxmzqxyppy
branch
from
2396e7e to
de587a6
Compare
|
Is there anything else I should do for this? |
isuffix
force-pushed
the
push-tsyxmzqxyppy
branch
from
de587a6 to
6f93a37
Compare
isuffix
force-pushed
the
push-tsyxmzqxyppy
branch
3 times, most recently
from
d3c90e2 to
2d0437b
Compare
isuffix
force-pushed
the
push-tsyxmzqxyppy
branch
from
2d0437b to
ffddcd7
Compare
Note that the actual error message is almost always the same. They all end up with the message "Failed to read working copy state" in `tree_state`. So the original code adding another equivalent message is unnecessary.
isuffix
force-pushed
the
push-tsyxmzqxyppy
branch
from
ffddcd7 to
9ada5d7
Compare
martinvonz
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally just added these with a
Fromimpl like below. But I figure that just extending the enums is prefered. Let me know if theFromimpl would be better instead.I also have two TODO comments where I wasn't sure whether converting the error type automatically would be an improvement. I would appreciate feedback on those.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)