Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: print prompt candidates to stderr, simplify choice handling #5999

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Mar 12, 2025

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Sorry, something went wrong.

yuja added 2 commits March 13, 2025 20:23
Follows up 0c7357e "ui: write prompt messages to stderr."

I also removed &mut since writing to Ui doesn't require mutable reference.
It's easier to process index than re-parsing stringified choice.
@yuja yuja force-pushed the push-mvowlylotqvo branch from 4b2bdef to 27b8b68 Compare March 13, 2025 11:27
@yuja yuja added this pull request to the merge queue Mar 15, 2025
Merged via the queue into jj-vcs:main with commit 67a2f41 Mar 15, 2025
25 checks passed
@yuja yuja deleted the push-mvowlylotqvo branch March 15, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants