docs workflow: try to fix it a third time #5820
Conversation
|
I think I figured out what the problem actually is. It's I won't merge this until I research it a bit more. For example, will fixing |
|
Yes, I think this is a proper fix now. I think the security implications are OK, but if there's doubt, we don't have to rush to merge this. (Though we should figure something out a few days before the upcoming release in a week) |
|
FYI, this is how the 
You need to unfold the appropriate triangles in https://github.com/jj-vcs/jj/actions/runs/13559508098/job/37899985506 to see this. |
ilyagr
force-pushed
the
ig/docsfix2
branch
2 times, most recently
from
20d22e7 to
731bd2b
Compare
I think I likely found the issue. zizmor seems OK with persisting credentials, see https://github.com/jj-vcs/jj/actions/runs/13559693565/job/37900455060?pr=5820 Both of these workflows run only on commits in `main`, so this doesn't seem like a huge security hole, but we could consider other, better solutions in the future. Follow up to 78177ff. See #5819 for a failed attempt. cc @thoughtpolice @neongreen @martinvonz
|
I added one more comment here. I'll probably still start the merge process soon, but feel free to cancel it and let me know if you don't like it. The comment is: |
See commit description for more.
Some relevant PRs:
#5819
#5807
#5076
cc @thoughtpolice @neongreen @martinvonz
See https://github.com/jj-vcs/jj/actions/runs/13559508098/job/37899985506 . The
GH_PAGESvariable is populated, but we get the same error.