Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): Make all error notifications sticky. #15586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damencho
Copy link
Member

@damencho damencho commented Feb 7, 2025

There are many cases where the error disappears and users easily miss the information.

@damencho damencho force-pushed the error-notifications branch from 0ce0228 to de40679 Compare February 7, 2025 20:51
* @returns {Object}
*/
export function showErrorNotification(props: INotificationProps, type?: string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not leave the type argument but put a default value NOTIFICATION_TIMEOUT_TYPE.STICKY?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, leaves the flexibility there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not leave the type argument but put a default value NOTIFICATION_TIMEOUT_TYPE.STICKY?

Will, do thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@saghul
Copy link
Member

saghul commented Feb 7, 2025

Have you checked with @yanas ? We went through all the timeouts at some point, and having too many as sticky was seen as problematic.

@damencho
Copy link
Member Author

damencho commented Feb 7, 2025

Yep,

Have you checked with @yanas ? We went through all the timeouts at some point, and having too many as sticky was seen as problematic.

Yep. We did not go through all of them, but agreed that errors need to be sticky so people acknowledge them. But for example there was a situation where someone did not notice that jibri failed.

There are many cases where the error disappears and users easily miss the information.
@damencho damencho force-pushed the error-notifications branch from de40679 to fbeae84 Compare February 7, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants