Implement a general-purpose websocket client #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrozev
reviewed
Nov 24, 2020
| class WebSocketClientTest : ShouldSpec() { | ||
| override fun isolationMode(): IsolationMode? = IsolationMode.InstancePerLeaf | ||
|
|
||
| private val wsPort = Random.nextInt(1024, 65535).also { |
There was a problem hiding this comment.
This will fail randomly because of colisions. Do you know if there's a way to make ktor bind on an ephemeral port?
bgrozev
reviewed
Nov 24, 2020
| println("Server running on port $it") | ||
| } | ||
|
|
||
| private val client = HttpClient(CIO) { |
There was a problem hiding this comment.
I'm not sure if this is redundant (since WebSocketClient defaults to the same) or defined here for reuse?
bgrozev
reviewed
Nov 24, 2020
| Thread.sleep(1000) | ||
| ws.sendString("hello") | ||
| ws.stop() | ||
| Thread.sleep(1000) |
There was a problem hiding this comment.
What does this test for, just lack of exceptions? Are both sleep calls necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.