feat(prosody) - Added TURN_USERNAME and TURN_PASSWORD #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Jan 6, 2025
| transport = "tcp", | ||
| ttl = {{ $TURN_TTL }}, | ||
|
|
||
| {{ if $.Env.TURN_CREDENTIALS -}} |
There was a problem hiding this comment.
Shouldn't this just be .Env.TURN_CREDENTIALS ?
There was a problem hiding this comment.
Because .Env tries to access the Env field from the current scope rather than the root context.
In Go templates, the $ symbol refers to the root context. When accessing top-level variables like Env, we need to use $.Env instead of .Env to ensure we're accessing from the root scope rather than the current context.
There was a problem hiding this comment.
Ops, I forgot about that! Thanks for the reminder!
| algorithm = "turn", | ||
| {{- end }} | ||
|
|
||
| {{ if $.Env.TURN_USERNAME -}} |
| username = "{{$.Env.TURN_USERNAME}}", | ||
| {{- end }} | ||
|
|
||
| {{ if $.Env.TURN_PASSWORD -}} |
saghul
approved these changes
Jan 6, 2025
saghul
added a commit
that referenced
this pull request
Jan 13, 2025
* 3ba77e1 feat(prosody) - Added TURN_USERNAME and TURN_PASSWORD (#1989) * 82e98d2 web: Added P2P_STUN_SERVERS environment variable (#1990) * 02499f8 feat(grafana): prosody monitoring dashboard created (#1879) * 3af0725 web: add option param for Automatic Gain Control * 9bc57e2 misc: working on unstable
guillaumevillemont
added a commit
to matrix-org/docker-jitsi-meet
that referenced
this pull request
Jan 17, 2025
release * 3ba77e1 feat(prosody) - Added TURN_USERNAME and TURN_PASSWORD (jitsi#1989) * 82e98d2 web: Added P2P_STUN_SERVERS environment variable (jitsi#1990) * 02499f8 feat(grafana): prosody monitoring dashboard created (jitsi#1879) * 3af0725 web: add option param for Automatic Gain Control * 9bc57e2 misc: working on unstable
guillaumevillemont
added a commit
to matrix-org/docker-jitsi-meet
that referenced
this pull request
Jan 17, 2025
release * 3ba77e1 feat(prosody) - Added TURN_USERNAME and TURN_PASSWORD (jitsi#1989) * 82e98d2 web: Added P2P_STUN_SERVERS environment variable (jitsi#1990) * 02499f8 feat(grafana): prosody monitoring dashboard created (jitsi#1879) * 3af0725 web: add option param for Automatic Gain Control * 9bc57e2 misc: working on unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add support for TURN servers that don't implement draft-uberti-behave-turn-rest-00
Problem
Cloudflare TURN servers do not support the draft-uberti-behave-turn-rest-00 specification, which is the default method used by mod_external_services to generate TURN credentials (username and password).
Solution
Added two new environment variables:
TURN_USERNAME: Define a static TURN usernameTURN_PASSWORD: Define a static TURN passwordWhen
TURN_CREDENTIALSis not set, the module will not attempt to generate credentials using the draft-uberti-behave-turn-rest-00 method. Instead, it will use the static credentials if provided throughTURN_USERNAMEandTURN_PASSWORD.This change allows Prosody to work with TURN servers that don't implement the expired draft spec, such as Cloudflare TURN.
Reference