-
Notifications
You must be signed in to change notification settings - Fork 24
refactor: remove docarray dependency #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
3c27c54 to
3469de8
Compare
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
73d4a13 to
3b3a4a0
Compare
| ```python | ||
| from annlite import AnnLite | ||
|
|
||
| docs = [{'id': '0', 'embedding': [], 'price': 8}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use dummy embedding as the example? 'embedding': np.random.random([128]).astype(np.float32)
|
Maybe we can define a simple Anyway, this idea can be in a new PR instead. |
numb3r3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@numb3r3 I sitll want to do a change which is to set the key from which to extract the embedding, not always rely on embedding. SInce my idea is to expose via DocArray, I will not use Pydantic for this since the validation would come from DocArray. The idea here is that here it remains focused only on ANN search, nothing else |
32c9351 to
edace38
Compare
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
edace38 to
2af1eda
Compare
No description provided.