add optional rank at modules domain #11724
Open
+62
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
renanfranca
commented
Jan 14, 2025
•
renanfranca
commented
- related to New state for modules #10934
…ntic builder at JHipsterModuleResource.java
…uilder to not use Optional for rank
…the JHipsterModuleResourceBuilder
…ank at JHipsterModuleResource.java
murdos
reviewed
Jan 14, 2025
|
|
||
| import tech.jhipster.lite.shared.error.domain.Assert; | ||
|
|
||
| public record JHipsterModuleRank(String rank) { |
There was a problem hiding this comment.
How about using an enum instead?
pascalgrimaud
requested changes
Jan 14, 2025
|
|
||
| import tech.jhipster.lite.shared.error.domain.Assert; | ||
|
|
||
| public record JHipsterModuleRank(String rank) { |
There was a problem hiding this comment.
as we already know the possible value, I would use an enum here: RANK_S, RANK_A, etc
| @@ -14,6 +15,7 @@ public final class JHipsterModuleResource { | |||
| private final JHipsterModuleApiDoc apiDoc; | |||
| private final JHipsterModuleOrganization organization; | |||
| private final JHipsterModuleTags tags; | |||
| private final Optional<JHipsterModuleRank> rank; | |||
There was a problem hiding this comment.
no need to be optional here, as there is a default value to RANK_D
| @@ -24,6 +26,7 @@ private JHipsterModuleResource(JHipsterModuleResourceBuilder builder) { | |||
| apiDoc = builder.apiDoc; | |||
| tags = builder.tags; | |||
| organization = builder.organization; | |||
| rank = Optional.ofNullable(builder.rank).or(() -> Optional.of(new JHipsterModuleRank("D"))); | |||
There was a problem hiding this comment.
would be something like Optional.ofNullable(builder.rank).orElse(JHipsterModuleRank.RANK_D);
|
Thank you for the reviews. I will work on this tomorrow ✌️😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.