Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: add missing test for RestManagementRepository #10948

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

qmonmert
Copy link
Contributor

No description provided.

@murdos murdos changed the title Generator: add missing test Generator: add missing test for RestManagementRepository Sep 22, 2024
@qmonmert
Copy link
Contributor Author

@pascalgrimaud ok to merge this PR and #10949 ?

@murdos
Copy link
Contributor

murdos commented Sep 29, 2024

@qmonmert : these tests are really testing implementation details.
I'd like to not require them by using code coverage from component tests instead: #10950

@renanfranca
Copy link
Contributor

@qmonmert and @murdos : Hello, I add a new comment at this discussion Code coverage 100% for front-end generated apps. I think it is related with this pull request.

@pascalgrimaud
Copy link
Member

I agree : these tests are really testing implementation details

But should we totally exclude what is in infrastructure folder ? But in this case, we can write bad + wrong code in infrastructure, so Cypress will become mandatory to protect that.

My small opinion (and probably wrong) would be:

  • we can merge this one
  • it's already done and won't take time to maintain
  • for real projects, the user will be free to ignore infrastructure folder or not

@qmonmert
Copy link
Contributor Author

@murdos ok to merge this?

@murdos
Copy link
Contributor

murdos commented Nov 11, 2024

Go ahead.
When I'm going to finish #10950, I'll evaluate if I remove it or not.

@qmonmert qmonmert merged commit ae11e4d into jhipster:main Nov 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants