Remove PHP 7.4 and Drupal 9 testing from CI. #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
force-pushed
the
feature/remove-php7.4-ci
branch
7 times, most recently
from
f2ecadd to
3445345
Compare
AlexSkrypnyk
force-pushed
the
feature/remove-php7.4-ci
branch
from
3445345 to
ac9e2e3
Compare
Collaborator
|
So if I'm not wrong this also fixes #697, right? It look good to me. I was surprised you didn't hit the problem when testing two different languages that I hit, but it seems Behat itself fixed that because it doesn't happen now in the commits it happens a few weeks ago. Given that, I'm favouring this PR over mine because is cleaner (no need the obscure hack of testing English features and Spanish features separately) and covers the same fixes and more. I would merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #697