Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-3895: Make variables root configurable #3906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabor-kormany
Copy link

@gabor-kormany gabor-kormany commented Sep 16, 2024

This is a bugfix.

Issue-3895

Proposed solution

Make the css variables host configurable instead of hardcoded :root. This allows the usage where the css is expected to be scoped with a class and also in web components where the :root selector is not available, but :host is.

Tradeoffs

Testing Done

I've tested this be creating a test.scss file with the following content:

@use "sass" with (
  $variables-host: ':host'
);

Made the output css file variables under :host as expected.

Changelog updated?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant