Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update font-family variables #3877

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rosepetal2022
Copy link

Fixes issue# 3863

Choose one of the following:

This is an improvement.

Proposed solution

This PR improves the consistency of font-family usage across the project by replacing hardcoded font-family values with CSS variables. This change ensures that font styles are managed more centrally, making future updates easier and promoting better maintainability.

Tradeoffs

The main tradeoff is that using CSS variables requires browser support. However, most modern browsers support CSS variables, so this is not a significant issue. This approach also increases the reliance on variables for styling, which might add a slight overhead to the CSS parsing process. Alternatives include keeping hardcoded values or using a preprocessor for variable management.

Testing Done

I tested the CSS changes using a minimal HTML file that includes the updated font-family variables. The changes were verified by comparing the visual output with the previous styles. I also tested the changes in different browsers to ensure consistency.

Changelog updated?

No. The Changelog has not been updated. If you think this change should be reflected in the Changelog, please let me know.

How have you confirmed this feature works?

I confirmed the feature works by creating a minimal HTML test file that applies the updated font-family variables. The visual output was checked to ensure the correct fonts were applied. Additionally, I tested the changes in multiple browsers to verify compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant